API Fetch: Improve isMediaUploadRequest check #34417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Media
7 tasks
|
This worked for me as advertised, and when applied to #34389 it correctly paged the result set for galleries over 100 when per_page set to -1. I don't think I have enough background around this part of the code though to sign off on it. @youknowriad, can you see any gotchas with this since you initially added this middleware? The background is that this change is needed to switch the gallery |
Mamaduka
force-pushed
the
fix/is-media-upload-request-check
branch
from
97a4f68 to
cc7e3df
Compare
|
Size Change: +20 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
Sorry for another ping, @youknowriad. I would love to hear your opinion about this change. |
youknowriad
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
I think it was @azaozz that implemented this initially.
It does make sense to limit it to "post" requests (maybe "put" too if that's supported)?
Also, we do have an HTTP1 middleware that transforms "post" to "get" requests, we need to make sure it's applied after this one.
|
Thanks for the review, @youknowriad.
I think API currently only supports uploads via the
The |
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
isMediaUploadRequestcheck and to allowper_page=-1get requests for media items.Fixes #34410.
How has this been tested?
Unit tests are running locally:
Running the following code in the browser console doesn't result in the error -
400: Invalid parameter(s): per_pageCheck that
mediaUploadMiddlewareis applied to upload requests. This can be done by checking the "Request call stack" in the Network tab.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).